Skip to content

[Benchmarks] Pin benchmarks to small set of cores #20403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 13, 2025
Merged

[Benchmarks] Pin benchmarks to small set of cores #20403

merged 13 commits into from
Nov 13, 2025

Conversation

@PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Oct 20, 2025

For better results stability, pin benchmark binaries to four cores with the maximum available frequency.

@PatKamin PatKamin requested review from a team as code owners October 20, 2025 17:39
@PatKamin PatKamin force-pushed the pin-4-cores-for-benches branch from 10804b3 to 8855934 Compare October 20, 2025 18:54
@PatKamin
Copy link
Contributor Author

PatKamin commented Oct 21, 2025

Test run on the PVC perf machine: https://github.com/intel/llvm/actions/runs/18679758239/job/53258464661

lukaszstolarczuk
lukaszstolarczuk reviewed Oct 21, 2025
View reviewed changes
@PatKamin PatKamin requested review from a team and vinser52 October 21, 2025 12:06
@PatKamin
[Benchmarks] Pin benchmarks to small set of cores
21fa7fb 
For better results stability, pin benchmark binaries to four cores with the maximum available frequency.
lslusarczyk
lslusarczyk reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@lslusarczyk lslusarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

@PatKamin PatKamin force-pushed the pin-4-cores-for-benches branch from 8855934 to e5b651a Compare October 22, 2025 10:08
lslusarczyk
lslusarczyk reviewed Oct 22, 2025
View reviewed changes
lukaszstolarczuk
lukaszstolarczuk reviewed Oct 22, 2025
View reviewed changes
@PatKamin PatKamin force-pushed the pin-4-cores-for-benches branch from e5b651a to 670adfc Compare October 22, 2025 14:50
lukaszstolarczuk
lukaszstolarczuk approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatKamin
Copy link
Contributor Author

PatKamin commented Oct 31, 2025

@intel/dpcpp-devops-reviewers, is adding numactl package to docker images ok?

@PatKamin PatKamin requested a review from lslusarczyk November 5, 2025 09:29
@PatKamin
Remove check for same frequency
c9767f5 
CPU driver sometimes changes a bit the maximum frequency of selected cores. This, however, doesn't impact benchmark results greatly. Assumption of having first cores with highest frequency is enough.
@PatKamin
Merge remote-tracking branch 'upstream/sycl' into pin-4-cores-for-ben…
ffc0abc 
…ches
@PatKamin
[TEST] Install numactl
127b519
@PatKamin
Merge remote-tracking branch 'upstream/sycl' into pin-4-cores-for-ben…
49bdcd3 
…ches
@PatKamin
Copy link
Contributor Author

PatKamin commented Nov 12, 2025

@intel/dpcpp-devops-reviewers, please review. This change will help stabilize benchmark results on the new BMG machine.

Note that benchmark job that actually uses numactl installed passed: https://github.com/intel/llvm/actions/runs/19104203407/job/55173686283.
The benchmark job that runs automatically for this PR doesn't have numactl package installed yet, so its result can be neglected.

As to the e2e test failure, it's unrelated.

@PatKamin
Copy link
Contributor Author

PatKamin commented Nov 13, 2025

@intel/dpcpp-devops-reviewers, a friendly ping. This patch should also fix failing benchmarks on BMG machine: https://github.com/intel/llvm/actions/runs/19328176408/job/55285113356#step:19:2263

@PatKamin PatKamin mentioned this pull request Nov 13, 2025
Merged
lukaszstolarczuk
lukaszstolarczuk reviewed Nov 13, 2025
View reviewed changes
lukaszstolarczuk
lukaszstolarczuk reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, LGTM

@sarnex
Copy link
Contributor

sarnex commented Nov 13, 2025

@PatKamin Is this ready for merge? Is the benchmark CI fail unrelated?

@lslusarczyk
Copy link
Contributor

lslusarczyk commented Nov 13, 2025

@PatKamin Is this ready for merge? Is the benchmark CI fail unrelated?

Yes. As @PatKamin informed me, it is ready to merge and benchmarks fail will be fixed by dockers rebuilding this night.
Please merge.

@sarnex sarnex merged commit 20dd0bc into intel:sycl Nov 13, 2025
42 of 47 checks passed
@PatKamin PatKamin deleted the pin-4-cores-for-benches branch November 13, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@sarnex sarnex sarnex approved these changes

@vinser52 vinser52 vinser52 approved these changes

@pbalcer pbalcer pbalcer approved these changes

@lslusarczyk lslusarczyk lslusarczyk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PatKamin @sarnex @lslusarczyk @vinser52 @pbalcer @lukaszstolarczuk